Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make health check parameters configurable for deployments #7698

Open
rockycodes opened this issue Jun 6, 2024 · 1 comment · May be fixed by civiform/cloud-deploy-infra#389
Open

Make health check parameters configurable for deployments #7698

rockycodes opened this issue Jun 6, 2024 · 1 comment · May be fixed by civiform/cloud-deploy-infra#389
Labels
deploy Work for the deploy directory or to enable new deployments

Comments

@rockycodes
Copy link
Contributor

A successful deployment is dependent on health checks passing for the container and for the load balancer. Sometimes these health checks take longer which can lead to a "failure" even when the container is actually healthy. We want to allow these checks to be configurable for individual deployments so they can up the time between checks or other parameters to allow a deployment to succeed.

Container health check: https://github.com/civiform/cloud-deploy-infra/blob/9f3c34c81f62ef0bcdcb26242bef094a5126d776/cloud/aws/templates/aws_oidc/app.tf#L111
Load balancer health check: https://github.com/civiform/cloud-deploy-infra/blob/9f3c34c81f62ef0bcdcb26242bef094a5126d776/cloud/aws/modules/ecs_fargate_service/main.tf#L130

@rockycodes rockycodes added the deploy Work for the deploy directory or to enable new deployments label Jun 6, 2024
@yegle yegle self-assigned this Jun 10, 2024
@yegle
Copy link
Collaborator

yegle commented Sep 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Work for the deploy directory or to enable new deployments
Projects
Status: Needs Triage
2 participants