Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Show LoRA/Checkpoint name in node #4

Open
DoogeJ opened this issue Aug 5, 2023 · 4 comments
Open

[Feature request] Show LoRA/Checkpoint name in node #4

DoogeJ opened this issue Aug 5, 2023 · 4 comments

Comments

@DoogeJ
Copy link

DoogeJ commented Aug 5, 2023

When using multiple, it can sometimes be hard to realize which one is which:
image

Having the node show the name once loaded would be great (even the filename itself is already nice to have!).

Optionally a link to the page for easy access to usage instructions would be amazing.

@WASasquatch
Copy link
Collaborator

I know this is a real frustration. Currently ComfyUI provides no way to override fields before/after execution, let alone even output some simple text to a node. There has been several discussions about how to appropriately handle these, but nothing has materialized.

That being said, once a model is downloaded, you can hit the "Refresh" button on the ComfyUI Menu and it should refresh the lora_name list. That way you can just select the newly download file and override the AIR tag.

@DoogeJ
Copy link
Author

DoogeJ commented Aug 6, 2023

Thanks, yes I found that indeed!

@TomLucidor
Copy link

People do change their name of models in the title (e.g. initial bad translation from another language) so it needs to be updated once and a while. The versioning tho should be more consistent I think?

@WASasquatch
Copy link
Collaborator

People do change their name of models in the title (e.g. initial bad translation from another language) so it needs to be updated once and a while. The versioning tho should be more consistent I think?

It probably wouldn't be a good idea to scan all LORAs and generate hashes all the time to compare changed filenames on the system. It would slow down workflow execution which is naturally at a premium in most people's flows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants