Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database software type value input should be more flexible #395

Closed
fernando-villalba opened this issue Apr 26, 2024 · 0 comments · Fixed by #413
Closed

Database software type value input should be more flexible #395

fernando-villalba opened this issue Apr 26, 2024 · 0 comments · Fixed by #413

Comments

@fernando-villalba
Copy link
Contributor

Issue

Running the following command:

civo database create db-psql --software psql

Gives this output:

Please check if you are using the latest version of CLI and retry the command 
If you are still facing issues, please report it on our community slack or open a GitHub issue (https://github.com/civo/cli/issues) 
Error: The provided software name is not valid. Make sure you use correct capitalization (e.g. MySQL, PostgreSQL)

Aside from the generic error which is useless in this scenario, there are a couple of issues here:

1. The values that can be provided here should be more flexible.

They should not be case sensitive, and they should accept shorthand form of the db name. For example it should accept postgresql as well as PostgreSQL and psql and PSQL. This would make the usage more intuitive.

2. The --software flag is a little strange, wouldn't --type be more fitting?

This one is as big of a deal, but I feel that the conceptual model of the user is more inclined to use --type as a flag for this than --software

Acceptance Criteria

  • Accept shorthands for databases and make the names case insensitive.
  • Reconsider the name of the flag --> Not as important, required to close this ticket.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant