Rollback weird behaviour?

[MennoM]

Hiya! I've just been toying around with this plugin and found some weird behaviour with the rollback function, just checking in if this is intended or not.

After making a modification on a model that has the MustBeApproved trait an approval gets created, after approving this change and then making a rollback on the same change, in my opinion, something weird happens

Because the rollback itself is another change on the model, changing the data to it's previous version, another approval gets made about the same interaction:

• the initial approval including the rolled back date, which has the state pending
• a new approval about changed data on the model

Which of these changes needs to be approved now?
Is it possible to not make a modification approval about the reverted data, which is already included in the original rolled-back approval?

[cjmellor]

Hi,

Yeah, you're right, it shouldn't do another Approval after doing a Rollback -- makes no sense really.

Perhaps something I over looked and should look into.

Thanks for the heads up.

Edit

I've just checked the code and tests and clearly I went into this feature with the idea of approving the rollback... which in hindsight isn't the best DX, so I'll have a look at making a change to where both situations are accounted for.

[cjmellor]

Nice one. I'll be sure to look into that too.

Open to a PR too as can't say exactly when I'll get to it 😬

[cjmellor]

@MennoM Any chance you could give me a clearer example of how you got to the error, like list the steps you took?

Thanks

[MennoM]

This is done in Laravel 10

Let's say I've got the following Model:
class Post extends Model
{
use MustBeApproved;

protected $fillable = [
    "config",
];

protected $casts = [
    "config" => "json",
];

}

Now let's assume we're making different API calls where we change this Model and approve the modifications, the creation works fine
$post = new Post(); $post->config = ['checked' => false]; $post->save();

When updating the post (which needs an approval)
$post = Post::find([id]); $post->config = ['checked' => true]; $post->save();

I get the following approvals, which I already approved in this image, but you can already see the discrepancy in data

after rolling back this change I get the following approvals

Now after approving the rolled-back approval (which is pending as well) I get the error "message": "json_decode(): Argument #1 ($json) must be of type string, array given", "exception": "TypeError", "file": "/var/www/html/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Casts/Json.php"

[cjmellor]

Hey @MennoM

Thanks for this, it'll help!

Just an FYI, v1.4.4 hopefully covers the issue you originally brought up, regarding rollbacks needs an Approval.

Once I find some time I can look at the other bits you brought up -- though I'm definitely open to a PR for it too.

Thanks

[MennoM]

Thanks for the heads up and the quick replies!
I've just created #54 for you, hope you can look into that

[cjmellor]

Closed by #54