-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Support for ignore in package.json #273
Comments
Hey @shellscape, thanks for opening this issue. This is definitely an oversight if that's the case. It might also just be missing from the I agree that people should be able to do something like this in their {
"graphql-schema-linter": {
"ignore": {
"fields-have-descriptions": ["Obvious", "Query.obvious", "Query.something.obvious"]
}
}
} If this is actually broken, I would start by looking here: https://github.com/cjoudrey/graphql-schema-linter/blob/c2876f3b93bd2a262c2af838f17cca5e21c23848/src/options.js |
I took a closer look and we have a test for this use case: graphql-schema-linter/test/config/package_json/test.js Lines 52 to 76 in c2876f3
So either the test is broken or perhaps we're just missing some documentation in the |
Yeah my first stop was the README. The text here: https://github.com/cjoudrey/graphql-schema-linter#configuration-file, states that |
FWIW I tried the ignore syntax in package.json and it worked fine for me.
|
Seems to work fine in package.json, but I couldn't get it to work with I have this in my package.json, working quite alright with a TypeGraphQL generated schema.
|
I must admit I'm a bit baffled as to why
--ignore
accepts JSON but not from package.json, where the format is also JSON. If at all possible, please consider supporting theignore
option within package.json. It would save a whole lot of headache. 🍻The text was updated successfully, but these errors were encountered: