Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holy war (and similar) distance check is kind of weird #203

Open
Silversweeper opened this issue Aug 2, 2024 · 0 comments
Open

Holy war (and similar) distance check is kind of weird #203

Silversweeper opened this issue Aug 2, 2024 · 0 comments

Comments

@Silversweeper
Copy link
Contributor

Consistent with vanilla CK2, but the "Neighbour of within two sea zones" check that is used in a few places (holy wars being one) checks if any county in the duchy is within one/two sea zones, not just the defender's counties. This can result in some possibly undesirable things, e.g. the Fatimids bypassing their Nubian/Ethiopian tributaries to attack someone with an inland county in a duchy because they are close enough to a coastal county held by a third party realm in the same duchy.

As a fix, I would suggest putting the "location" part of the check in an AND together with holder_scope = { OR = { character = FROM is_vassal_or_below_of = FROM } }; it's a change to vanilla, but probably how it's intended to work, and it'd mean fewer crimes against bordergore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant