Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add directories from plugins if partially string matches existing values #5836

Closed
wardi opened this issue Jan 18, 2021 · 0 comments · Fixed by #5837
Closed

Can't add directories from plugins if partially string matches existing values #5836

wardi opened this issue Jan 18, 2021 · 0 comments · Fixed by #5837
Assignees

Comments

@wardi
Copy link
Contributor

wardi commented Jan 18, 2021

CKAN version
1.7 or so

Describe the bug
If you add a served directory that partially string matches existing values it will be ignored

Steps to reproduce

if old_ckan:
    add_template_directory(config, 'templates-for-old-ckans')
add_template_directory(config, 'templates')

Expected behavior
when old_ckan is True I expect both template directories to be in the template search path

Additional details
only the /path/to/my/extension/templates-for-old-ckans appears in the template search path

wardi added a commit that referenced this issue Jan 18, 2021
Allow adding template and public dirs even if they are a partial string match of existing dirs
@amercader amercader self-assigned this Jan 19, 2021
amercader added a commit that referenced this issue Jan 22, 2021
amercader pushed a commit that referenced this issue Jan 28, 2021
Allow adding template and public dirs even if they are a partial string match of existing dirs
amercader pushed a commit that referenced this issue Jan 28, 2021
Allow adding template and public dirs even if they are a partial string match of existing dirs
amercader pushed a commit that referenced this issue Jan 28, 2021
Allow adding template and public dirs even if they are a partial string match of existing dirs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants