Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates malformed type if route param contains a dash #14

Closed
osdiab opened this issue Nov 11, 2021 · 0 comments · Fixed by #16
Closed

Creates malformed type if route param contains a dash #14

osdiab opened this issue Nov 11, 2021 · 0 comments · Fixed by #16

Comments

@osdiab
Copy link
Collaborator

osdiab commented Nov 11, 2021

it created this route, for instance:

{ route: "/countries/[encoded-country]", params: { encoded-country: string | number }, query?: Query }

The created type ought to have quotes to avoid this (and i guess if a route has quotes in it, it should probably escape the quotes too looks like quotes are not allowed in query parameters at all so that's fine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant