Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types not saved in the correct place on windows #27

Closed
osdiab opened this issue Nov 14, 2021 · 2 comments · Fixed by #28
Closed

Types not saved in the correct place on windows #27

osdiab opened this issue Nov 14, 2021 · 2 comments · Fixed by #28

Comments

@osdiab
Copy link
Collaborator

osdiab commented Nov 14, 2021

I still need to figure out why this is happening, but my teammate on a project is experiencing a strange issue where the @types folder is being placed in the src/pages directory instead of the src directory for him. Will take a look at the code and chat with him more to see if I can find out what might be going on. Related to #18

EDIT: turns out i was right, slashes are reversed in windows:

{
  pagesDir: 'C:\\Users\\gus\\Documents\\dev\\spinach\\web-app\\src\\pages'
}

the code needs to be tolerant of that, and also probably should not just be a regex replace (if /pages is anywhere else in the path it'll break)

@osdiab
Copy link
Collaborator Author

osdiab commented Nov 14, 2021

I suspect it might be that he's on windows and the slashes are reversed? But double checking by asking him to print out what the pagesDir value is

@osdiab osdiab changed the title Types not saved in the same place consistently for the same project Types not saved in the correct place on windows Nov 15, 2021
@airtonix
Copy link

this is only true if you use cmd.exe .

most people will now be using powershell by default or wsl2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants