feat(sample): view for sample #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daryl-L
force-pushed
the
feature/sample-project-view
branch
from
def4e7c
to
5fdc2b7
Compare
Daryl-L
requested review from
PainterPuppets,
Keith-CY,
yanguoyu and
zhengjianhui
Keith-CY
reviewed
Feb 4, 2023
|
I think |
Daryl-L
force-pushed
the
feature/sample-project-view
branch
from
5fdc2b7
to
87f2f4c
Compare
I just referred to what @PainterPuppets did. |
yanguoyu
approved these changes
Feb 6, 2023
Keith-CY
reviewed
Feb 6, 2023
|
|
||
| txSkeleton.update('witnesses', (witnesses) => { | ||
| if (witness === '0x' || witness === '') { | ||
| const omniLock = config.getConfig().SCRIPTS.OMNI_LOCK as NonNullable<config.ScriptConfig> |
There was a problem hiding this comment.
Seems that chain type mainnet/testnet is not set, but we can do it later.
Keith-CY
approved these changes
Feb 6, 2023
This was referenced Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.