Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kuai contract deploy command support export tx file #291

Merged
merged 1 commit into from
May 31, 2023

Conversation

PainterPuppets
Copy link
Contributor

@PainterPuppets PainterPuppets commented May 31, 2023

update kuai conract deploy command for support export workflow

  • add --export flag
  • add --bin-path flag
  • add --send flag, tx is now not sent directly without —send flag
  • add --no-type-id flag
  • change --feeRate flag to --fee-rate

export workflow example :

  1. kuai contract deploy --name sample-dapp --from ckt1qyqw8yx5hx6vwcm7eqren0d0v39wvfwdhy3q2807pp --export ./tx.json
image
  1. ckb-cli tx sign-inputs --tx-file ./tx.json --from-account 0xe390d4b9b4c7637ec80799bdaf644ae625cdb922 --add-signatures
image
  1. ckb-cli tx send --tx-file ./tx.json
image

export workflow with multisig

  1. kuai contract deploy --name sample-dapp --from multisig 0 2 0xe390d4b9b4c7637ec80799bdaf644ae625cdb922 0xb6ddba87bb5af5f053b1ae5bcbc7f4de03479f7e --export ./tx.json
image
  1. ckb-cli tx sign-inputs --tx-file ./tx.json --from-account 0xe390d4b9b4c7637ec80799bdaf644ae625cdb922 --add-signatures
image
  1. ckb-cli tx sign-inputs --tx-file ./tx.json --from-account ckt1qyqtdhd6s7a44a0s2wc6uk7tcl6duq68nalqvzxw09 --add-signatures
image
  1. ckb-cli tx send --tx-file ./tx.json
image

directly deploy (before method)

kuai contract deploy --bin-path ./sample-dapp --from ckt1qyqw8yx5hx6vwcm7eqren0d0v39wvfwdhy3q2807pp --signer ckb-cli --send
image

@codecov-commenter
Copy link

Codecov Report

Merging #291 (ffec14a) into develop (4ccc830) will decrease coverage by 1.78%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #291      +/-   ##
===========================================
- Coverage    70.68%   68.90%   -1.78%     
===========================================
  Files           85       85              
  Lines         2500     2631     +131     
  Branches       565      596      +31     
===========================================
+ Hits          1767     1813      +46     
- Misses         664      733      +69     
- Partials        69       85      +16     
Impacted Files Coverage Δ
packages/core/src/errors-list.ts 100.00% <ø> (ø)
packages/core/src/builtin-tasks/contract.ts 21.15% <9.09%> (-4.78%) ⬇️
packages/core/src/contract.ts 18.75% <16.66%> (-2.68%) ⬇️
packages/core/src/runtime.ts 91.37% <100.00%> (+0.15%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ccc830...ffec14a. Read the comment docs.

@Keith-CY Keith-CY merged commit a7330e4 into develop May 31, 2023
@Keith-CY Keith-CY deleted the contract_command_support_export branch May 31, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants