Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement the registry with a container #50

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

Keith-CY
Copy link
Member

@Keith-CY Keith-CY commented Nov 30, 2022

This PR implements the registry of actor models with a container
which scans modules on initiation to bind user-defined actor classes
into the container and instantiate them on demand

Once the project starts, the registry will scan all files and bind classes
decorated by ActorProvider into the container and instantiate them
lazily by calling registry.find(uri)

Ref: #39

@Keith-CY Keith-CY force-pushed the add-actor-registry branch 3 times, most recently from 1650e7e to 1df5bf5 Compare November 30, 2022 17:23
@Keith-CY Keith-CY marked this pull request as ready for review November 30, 2022 17:23
@Keith-CY Keith-CY added the enhancement New feature or request label Nov 30, 2022
@Keith-CY Keith-CY self-assigned this Nov 30, 2022
This PR implements the registry of actor models with a container
which scans modules on initiation to bind user-defined actor classes
into the container and instantiate them on demand

Once the project starts, registry will scan all files and bind classes
decorated by `ActorProvider` into the container and instantiate them
lazily by calling `registry.find(uri)`
Co-authored-by: 严国宇 <841185308@qq.com>
Copy link
Contributor

@PainterPuppets PainterPuppets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Keith-CY Keith-CY merged commit e4435e0 into develop Dec 5, 2022
@Keith-CY Keith-CY deleted the add-actor-registry branch December 5, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants