-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement the registry with a container #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keith-CY
force-pushed
the
add-actor-registry
branch
3 times, most recently
from
November 30, 2022 17:23
1650e7e
to
1df5bf5
Compare
This PR implements the registry of actor models with a container which scans modules on initiation to bind user-defined actor classes into the container and instantiate them on demand Once the project starts, registry will scan all files and bind classes decorated by `ActorProvider` into the container and instantiate them lazily by calling `registry.find(uri)`
Keith-CY
force-pushed
the
add-actor-registry
branch
from
November 30, 2022 17:30
1df5bf5
to
bf7dece
Compare
felicityin
approved these changes
Dec 1, 2022
yanguoyu
reviewed
Dec 1, 2022
yanguoyu
reviewed
Dec 1, 2022
Co-authored-by: 严国宇 <841185308@qq.com>
PainterPuppets
approved these changes
Dec 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yanguoyu
approved these changes
Dec 5, 2022
This was referenced Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the registry of actor models with a container
which scans modules on initiation to bind user-defined actor classes
into the container and instantiate them on demand
Once the project starts, the registry will scan all files and bind classes
decorated by
ActorProvider
into the container and instantiate themlazily by calling
registry.find(uri)
Ref: #39