Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement store model #51

Merged
merged 17 commits into from
Jan 5, 2023
Merged

feat: Implement store model #51

merged 17 commits into from
Jan 5, 2023

Conversation

yanguoyu
Copy link
Contributor

  1. JSON storage
  2. Pattern define
  3. Store implement

@yanguoyu yanguoyu mentioned this pull request Nov 30, 2022
Open
5 tasks
@yanguoyu yanguoyu marked this pull request as ready for review December 3, 2022 05:36
PainterPuppets
PainterPuppets approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@PainterPuppets PainterPuppets left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually the serialization will have a validation solution, Store will have a similar solution?

@yanguoyu
Copy link
Contributor Author

yanguoyu commented Dec 7, 2022

a validation solution

Can you take an example?

@PainterPuppets PainterPuppets reopened this Dec 7, 2022
@PainterPuppets
Copy link
Contributor

a validation solution

Can you take an example?

sorry, point wrong

serialization of nest https://docs.nestjs.com/techniques/serialization https://github.com/typestack/class-validator

Keith-CY
Keith-CY reviewed Dec 7, 2022
View reviewed changes
.eslintrc.js Show resolved Hide resolved
packages/models/src/contract/index.ts Outdated Show resolved Hide resolved
packages/models/src/contract/index.ts Outdated Show resolved Hide resolved
Keith-CY
Keith-CY reviewed Dec 7, 2022
View reviewed changes
packages/models/src/exceptions/store.ts Outdated Show resolved Hide resolved
packages/models/src/store/chain-storage.ts Outdated Show resolved Hide resolved
packages/models/src/store/chain-storage.ts Outdated Show resolved Hide resolved
packages/models/src/store/json-storage.ts Outdated Show resolved Hide resolved
packages/models/src/store/json-storage.ts Outdated Show resolved Hide resolved
packages/models/src/store/json-storage.ts Outdated Show resolved Hide resolved
packages/models/src/store/json-storage.ts Outdated Show resolved Hide resolved
packages/models/src/store/json-storage.ts Outdated Show resolved Hide resolved
packages/models/src/store/store.ts Outdated Show resolved Hide resolved
packages/models/src/store/store.ts Outdated Show resolved Hide resolved
@yanguoyu
Copy link
Contributor Author

a validation solution

Can you take an example?

sorry, point wrong

serialization of nest https://docs.nestjs.com/techniques/serialization https://github.com/typestack/class-validator

Actual, it has valid the params for serialize and deserialize, and I add some test cases for it with b51e1f6.

@Keith-CY Keith-CY added the enhancement New feature or request label Dec 13, 2022
@Keith-CY Keith-CY added this to the 2022/12/01 - 2022/12/08 milestone Dec 13, 2022
@yanguoyu yanguoyu marked this pull request as draft December 26, 2022 03:07
@yanguoyu yanguoyu marked this pull request as ready for review December 26, 2022 08:19
@yanguoyu yanguoyu requested review from Daryl-L and zhengjianhui and removed request for felicityin December 26, 2022 08:34
Keith-CY
Keith-CY reviewed Dec 27, 2022
View reviewed changes
packages/models/src/exceptions/store.ts Outdated Show resolved Hide resolved
packages/models/src/store/store.ts Outdated Show resolved Hide resolved
@Keith-CY Keith-CY self-requested a review December 28, 2022 05:51
@Daryl-L Daryl-L mentioned this pull request Dec 28, 2022
Closed
@Daryl-L
Copy link
Contributor

Daryl-L commented Dec 29, 2022

I have a question, how can I instance the Store object from database, by using type script or lock script or both?

@Keith-CY
Copy link
Member

I have a question, how can I instance the Store object from database, by using type script or lock script or both?

Store is a mapping of cells specified by pattern, pattern is a combination of conditions as SQL(designed in #2 (comment)), e.g. lock.code_hash eq A and lock.hash_type eq B and lock.args eq C and type.code_hash eq D and type.hash_type eq F and type.args eq G and data like '%H%'

@Keith-CY
Copy link
Member

We will review this PR later because manipulation on type script and lock script is going to be implemented along with this feature.

Ref: #41 (comment)

@yanguoyu
Copy link
Contributor Author

lock and type schema have been added. @Keith-CY @Daryl-L @zhengjianhui @PainterPuppets

@Keith-CY
Copy link
Member

Keith-CY commented Jan 5, 2023

Here're 2 approvals so this PR is ready to merge once conflicts are resolved

@yanguoyu
feat: Implement store model
35f9773 
1. JSON storage
2. Pattern define
3. Store implement
@yanguoyu
feat: Add test case.
d590ef3
@yanguoyu
fix: Add some exception types for json storage. Use import type.
83980c8
@yanguoyu
fix: Fix test case.
78f72cc
@yanguoyu
fix: Return witness if witness exist.
9e10f67
@yanguoyu
test: Add test case for some exception.
a24e765
@yanguoyu
fix: Use better name for type
a1f7347
@yanguoyu
feat: Better template type name.
1a2c4db
@yanguoyu
fix: Use bignumber to merge bigint and number
1f296fc
@yanguoyu
fix: Fix testcase
e3e657d
@yanguoyu
feat: Optimize storage type define and add scriptType
989f40a
@yanguoyu
refactor: remove data and witness define to store.
98c7082 
After adding `scriptType` for the store, I found that `Storage` should not care about `data` and `witness`, they only need to `serialize` and `deserialize` from the defined struct.
@yanguoyu
refactor: Remove scriptType from store.
f73bd14 
1. Use template parameter to define `lock data` or `type data`, remove `scriptType`.
@yanguoyu
fix: Better type for parameter.
1db5b72
@yanguoyu
fix: Fix test case after rebase.
5618339
@yanguoyu
fix: Fix merge lockData and typeData into data.
bcec19a
@yanguoyu
feat: Add lock and type schema.
a048cdb 
1. Add lock and type schema.
2. Add offset and length for a schema.
@yanguoyu yanguoyu merged commit 373e79a into ckb-js:develop Jan 5, 2023
@yanguoyu yanguoyu deleted the feat-store branch January 5, 2023 06:24
This was referenced Jul 21, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhengjianhui zhengjianhui zhengjianhui approved these changes

@Daryl-L Daryl-L Daryl-L approved these changes

@PainterPuppets PainterPuppets Awaiting requested review from PainterPuppets

@Keith-CY Keith-CY Awaiting requested review from Keith-CY

Assignees

@yanguoyu yanguoyu

Labels
enhancement New feature or request
Projects
CKB JS Backlog
Archived in project
Milestone
2022/12/15 - 2022/12/22
Development

Successfully merging this pull request may close these issues.
5 participants
@yanguoyu @PainterPuppets @Daryl-L @Keith-CY @zhengjianhui