Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload widget paste listener ignores changes in the uploadWidgetDefinition #1068

Closed
mlewand opened this issue Oct 19, 2017 · 0 comments
Closed

Upload widget paste listener ignores changes in the uploadWidgetDefinition #1068

mlewand opened this issue Oct 19, 2017 · 0 comments
Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:uploadwidget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Milestone
4.8.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Oct 19, 2017

Are you reporting a feature or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Open https://codepen.io/mlewand/pen/mBvxeM.
  2. Open developer console.
  3. Drag any jpg file from your desktop, and drop it over the editor's editable.

Expected result

Black square should appear, no exceptions of missing method should be logged in the console.

Actual result

Exception Uncaught TypeError: d[m] is not a function is reported.

Other details

Reason why it happens is because addUploadWidget function in widgetupload plugin uses def that was given as an argument for the very first time. This object can not be modified by the widgetDefinition listeners.

The solution here is to simply get the definition from widgetRepository in paste listener.

Reproducible in all browsers.
@mlewand mlewand changed the title Uploadwidget paste listener ignores changes in the uploadWidgetDefinition Upload widget paste listener ignores changes in the uploadWidgetDefinition Oct 19, 2017
@mlewand mlewand added plugin:uploadwidget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. type:bug A bug. labels Oct 19, 2017
mlewand added a commit that referenced this issue Oct 23, 2017
@mlewand
Simplified tests, by fixing #1068 issue in listener for easyimage (on…
fb87b7f 
…ly).
@mlewand mlewand mentioned this issue Oct 23, 2017
Merged
2 tasks
Comandeer pushed a commit that referenced this issue Nov 6, 2017
@mlewand @Comandeer
Simplified tests, by fixing #1068 issue in listener for easyimage (on…
0891371 
…ly).
mlewand added a commit that referenced this issue Nov 6, 2017
@mlewand
Simplified tests, by fixing #1068 issue in listener for easyimage (on…
c5f35ab 
…ly).
@mlewand mlewand added this to the Backlog milestone Nov 9, 2017
@mlewand mlewand added the target:major Any docs related issue that should be merged into a major branch. label Nov 9, 2017
@mlewand mlewand mentioned this issue Nov 9, 2017
Merged
2 tasks
@mlewand mlewand modified the milestones: Backlog, 4.8.0 Nov 9, 2017
Comandeer pushed a commit that referenced this issue Nov 13, 2017
@mlewand @Comandeer
Simplified tests, by fixing #1068 issue in listener for easyimage (on…
c883658 
…ly).
@mlewand mlewand added the changelog:api A changelog entry should be put in the API section of the changelog. label Dec 1, 2017
Comandeer pushed a commit that referenced this issue Dec 5, 2017
@mlewand @Comandeer
Simplified tests, by fixing #1068 issue in listener for easyimage (on…
9b8e92b 
…ly).
Comandeer pushed a commit that referenced this issue Dec 27, 2017
@mlewand @Comandeer
Simplified tests, by fixing #1068 issue in listener for easyimage (on…
728510c 
…ly).
Comandeer pushed a commit that referenced this issue Dec 27, 2017
@mlewand @Comandeer
Simplified tests, by fixing #1068 issue in listener for easyimage (on…
7b25476 
…ly).
mlewand added a commit that referenced this issue Feb 5, 2018
@mlewand
Simplified tests, by fixing #1068 issue in listener for easyimage (on…
fb72da7 
…ly).
Comandeer pushed a commit that referenced this issue Feb 6, 2018
@mlewand @Comandeer
Simplified tests, by fixing #1068 issue in listener for easyimage (on…
980d62e 
…ly).
Comandeer pushed a commit that referenced this issue Feb 6, 2018
@mlewand @Comandeer
Simplified tests, by fixing #1068 issue in listener for easyimage (on…
2a63216 
…ly).
jacekbogdanski pushed a commit that referenced this issue Feb 17, 2018
@mlewand @jacekbogdanski
Simplified tests, by fixing #1068 issue in listener for easyimage (on…
c60881d 
…ly).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog:api A changelog entry should be put in the API section of the changelog. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:uploadwidget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Projects
None yet
Milestone
4.8.0
Development

No branches or pull requests
1 participant
@mlewand