Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on scrollbar throws error element.is is not a function #663

Closed
victor-kirillov opened this issue Jul 20, 2017 · 0 comments
Closed
Labels
browser:chrome The issue can only be reproduced in the Chrome browser. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@victor-kirillov
Copy link

Are you reporting a feature or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Add widget plugin or some plugin used it, for example upload image plugin in ckeditor build
  2. Make editor scrollable
  3. Click on scrollbar

Expected result

No error in the console.

Actual result

An error in the console:

Uncaught TypeError: element.is is not a function

Other details

An error comes from widget plugin: https://github.com/ckeditor/ckeditor-dev/blob/master/plugins/widget/plugin.js#L448

Can be simply reproduced on that page: http://sdk.ckeditor.com/samples/simplebox.html

Possible solution: add check if element has an is function here - https://github.com/ckeditor/ckeditor-dev/blob/master/plugins/widget/plugin.js#L452

There is similar issue #528 #515

  • Browser: Chrome 59
  • OS: Windows 10
  • CKEditor version: 4.7.1
  • Installed CKEditor plugins: Full version with upload image plugin and all required plugins
@msamsel msamsel added browser:chrome The issue can only be reproduced in the Chrome browser. status:confirmed An issue confirmed by the development team. type:bug A bug. labels Jul 20, 2017
@mlewand mlewand added the good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. label Jul 25, 2017
@wojtekw92 wojtekw92 self-assigned this Jul 26, 2017
@f1ames f1ames added this to the 4.7.2 milestone Aug 10, 2017
@wojtekw92 wojtekw92 removed their assignment Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:chrome The issue can only be reproduced in the Chrome browser. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

5 participants