Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move namespaceLoaded directive into events #69

Closed
jacekbogdanski opened this issue Nov 5, 2020 · 1 comment · Fixed by #70
Closed

Move namespaceLoaded directive into events #69

jacekbogdanski opened this issue Nov 5, 2020 · 1 comment · Fixed by #70
Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).

Comments

@jacekbogdanski
Copy link
Member

Are you reporting a feature request or a bug?

Provide detailed reproduction steps (if any)

When working on docs for #67 I find out that we probably misplaced our namespaceLoaded directive with the event. It seems more semantic to treat it as an event since it's asynchronous and it's called only in a specific environment. It would be good to move this directive into events instead, so instead of writing:

<ckeditor :namespace-loaded="callback" />

we would have

<ckeditor @namespaceloaded="callback" />

(I've changed the name of the event on purpose as it's probably more convenient to write events without - character, and the camel case is discouraged by Vue).

For more details about the feature see #66

@jacekbogdanski jacekbogdanski added type:task Any other issue (refactoring, typo fix, etc). status:confirmed An issue confirmed by the development team. size:XS labels Nov 5, 2020
@CKEditorBot
Copy link
Collaborator

Closed in #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants