Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balloon Toolbar tests are failing in small browser window #1076

Closed
wojtekw92 opened this issue Oct 23, 2017 · 6 comments
Closed

Balloon Toolbar tests are failing in small browser window #1076

wojtekw92 opened this issue Oct 23, 2017 · 6 comments
Assignees
@engineering-this
Labels
plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:failingtest A failing test.
Milestone
4.11.4

Comments

@wojtekw92
Copy link
Contributor

wojtekw92 commented Oct 23, 2017 •
edited by mlewand
Loading

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Open unit test http://tests.ckeditor.test:1030/tests/plugins/balloontoolbar/positioning.
  2. Resize window to height ~300-400px.
  3. Run tests.

Expected result

All test should be passed.

Actual result

Teat are failing on top align.

Other details

  • Browser: Windows, MacOS
  • OS: all
  • CKEditor version: 4.7.3
  • Installed CKEditor plugins: inlinetoolbar
@wojtekw92 wojtekw92 added status:confirmed An issue confirmed by the development team. type:bug A bug. labels Oct 23, 2017
@mlewand mlewand changed the title Inlinetoolbar tests are failing in small browser window. Inlinetoolbar tests are failing in small browser window Dec 15, 2017
@mlewand mlewand changed the title Inlinetoolbar tests are failing in small browser window Balloon Toolbar tests are failing in small browser window Dec 15, 2017
@mlewand mlewand added plugin:balloontoolbar The plugin which probably causes the issue. type:failingtest A failing test. labels Dec 15, 2017
@mlewand
Copy link
Contributor

mlewand commented Dec 15, 2017

Corrected test URL. However I can't reproduce this issue on Win10 (Chrome, Firefox, IE11, Edge). @msamsel @f1ames @Comandeer can any of you reproduce it?

@mlewand mlewand added status:pending and removed status:confirmed An issue confirmed by the development team. type:bug A bug. labels Dec 15, 2017
@mlewand mlewand mentioned this issue Dec 15, 2017
Merged
2 tasks
@msamsel
Copy link
Contributor

msamsel commented Dec 18, 2017 •
edited
Loading

@mlewand during 4.8.0 testing phase some positioning tests were ignored. It might be a reason why now tests are passing. #1307

@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Jun 26, 2018
@jacekbogdanski jacekbogdanski added the status:confirmed An issue confirmed by the development team. label Sep 17, 2018
@engineering-this engineering-this self-assigned this Dec 7, 2018
@engineering-this engineering-this mentioned this issue Dec 10, 2018
Merged
2 tasks
@Comandeer
Copy link
Member

Merged into 4.11.2.

@Comandeer Comandeer added this to the 4.11.2 milestone Dec 12, 2018
@mlewand
Copy link
Contributor

mlewand commented Jan 7, 2019 •
edited
Loading

See #2729 - looks like #2663 did not cut it. Scheduling for next minor release.

@mlewand mlewand reopened this Jan 7, 2019
@mlewand mlewand modified the milestones: 4.11.2, 4.11.3 Jan 7, 2019
@mlewand mlewand mentioned this issue Jan 7, 2019
Closed
This was referenced Feb 18, 2019
Merged
Closed
@engineering-this
Copy link
Contributor

Finally tracked source of iOS Safari issue. This isn't just failing test. Balloon toolbar might be wrongly positioned, that is because getting rect of an iframe returns rect of it's content doc instead of the actual rect on mobile Safari.

@mlewand mlewand modified the milestones: 4.11.3, 4.11.4 Feb 20, 2019
@f1ames
Copy link
Contributor

f1ames commented Mar 25, 2019

Closed with 3c4e2a3.

@f1ames f1ames closed this as completed Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engineering-this engineering-this

Labels
plugin:balloontoolbar The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:failingtest A failing test.
Projects
None yet
Milestone
4.11.4
Development

No branches or pull requests
7 participants
@f1ames @Comandeer @mlewand @wojtekw92 @msamsel @jacekbogdanski @engineering-this