Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should add new function to plugin API, which behaves like onLoad but after dependencies are loaded #1142

Open
wojtekw92 opened this issue Nov 9, 2017 · 0 comments
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.

Comments

@wojtekw92
Copy link
Contributor

wojtekw92 commented Nov 9, 2017

When we are developing plugin sometimes we are using dependencies to external plugins especially when we are making for example child class, we have to clone prototypes.

In existing plugin API we have methods:

onLoad - that method runs once but plugins dependencies doesn't have to be loaded. That make this method not best choice for cloning prototype.

init, beforeInit, afterInit - those function are executed after dependencies are available, but also are executed for every editor instance. So there is also not the best place for this.

Sugested solution

In my opinion we should add method like onDependencyLoaded that will run once but after plugin dependencies are available.

@wojtekw92 wojtekw92 changed the title overwritting support We should add new function to plugin API, which behaves like onLoad but after dependencies are loaded Nov 9, 2017
@wojtekw92 wojtekw92 added status:confirmed An issue confirmed by the development team. type:feature A feature request. labels Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Development

No branches or pull requests

1 participant