Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing tableselection/integration/selectall test #1277

Closed
Comandeer opened this issue Nov 29, 2017 · 2 comments · Fixed by #1290
Closed

Failing tableselection/integration/selectall test #1277

Comandeer opened this issue Nov 29, 2017 · 2 comments · Fixed by #1290
Assignees
@Comandeer
Labels
browser:chrome The issue can only be reproduced in the Chrome browser. browser:safari The issue can only be reproduced in the Safari browser. changelog:skip A changelog entry should not be added for a given issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:failingtest A failing test.

Comments

@Comandeer
Copy link
Member

Are you reporting a feature request or a bug?

Failing test

Provide detailed reproduction steps (if any)

screen shot 2017-11-29 at 16 41 48

Other details

  • Browser: Chrome 62.0.3202.94, Safari 11.0.1 (13604.3.5)
  • OS: macOS
  • CKEditor version: 4.80 (built version with uploadimage plugin enabled)
@Comandeer Comandeer added browser:chrome The issue can only be reproduced in the Chrome browser. browser:safari The issue can only be reproduced in the Safari browser. type:failingtest A failing test. labels Nov 29, 2017
@mlewand mlewand added the target:major Any docs related issue that should be merged into a major branch. label Nov 29, 2017
@msamsel msamsel added the status:confirmed An issue confirmed by the development team. label Nov 30, 2017
@Comandeer Comandeer self-assigned this Nov 30, 2017
@Comandeer
Copy link
Member Author

It seems that integration with selectall does not work due to selectionChange listener in widget plugin.

It's not new issue, introduced by changes in 4.8.0, it was just not caught earlier due to the fact that this test does not include widget plugin. The easiest way to fix failing test for now is to remove widget plugin, but then identical bug as #1278 occurs, which is being fixed by @f1ames.

@f1ames f1ames added the changelog:skip A changelog entry should not be added for a given issue. label Nov 30, 2017
@f1ames f1ames mentioned this issue Nov 30, 2017
Merged
2 tasks
@f1ames
Copy link
Contributor

f1ames commented Nov 30, 2017

It is basically widgetselection plugin which breaks this test. Look slike not a recent regression, it probably just was not tested in such configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Comandeer Comandeer

Labels
browser:chrome The issue can only be reproduced in the Chrome browser. browser:safari The issue can only be reproduced in the Safari browser. changelog:skip A changelog entry should not be added for a given issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:failingtest A failing test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove widget plugin from tableselection/integration/selectall test ckeditor/ckeditor4
4 participants
@f1ames @Comandeer @mlewand @msamsel