Widget issues in tables

[Comandeer]

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

All cases are based on https://jsfiddle.net/a8wrevzz/

Case 1

1. Click image's move handler
2. Try to move image.

Expected result

Image is moved.

Actual result

Table selection is activated, but image is not moved.

Case 2

1. Try to resize image using resize handler

Expected result

Image is resized.

Actual result

• Table selection is activated (especially in case of enlarging image).
• In rare cases image could be not resized at all.

Case 3

1. Click image.

Expected result

Widget is focused.

Actual result

Widget becomes focused, but immediately loses focus.

Other details

• Installed CKEditor plugins: tableselection, image2

[mlewand]

Actually this one is for the discussion:

I think that dragging a widget should cancel the mousedown event, since it basically takes over the whole process by displaying magic line etc. Also for consistency mousemove and mouseup should be also prevented (if following the mousedown and handled by widget ofc).

Table selection should have a lower priority than a widget selection, and would not be triggered if already handled by widget.

On a side note, table selection should do the same thing as for event cancellation.

[Comandeer]

It seems that lowering mouse listeners priorities in tableselection plugin and adding evt.stop to listeners in widget plugin partially fixes the issue. However there is still issue with dragging widget inside the table. After dragging and dropping it the first time, every attempt to write inside table just focuses the widget, making table practically uneditable.

[AlfonsoML]

For reference, these problems didn't exist previously (like 4.6.something), it's a regression that hurts the people that wants to upgrade.

[msamsel]

Case 2 - Also table selection activate when widget is dragged.

[Mgsy]

Steps to reproduce

1. Go to http://localhost:1030/tests/plugins/clipboard/manual/draganddrop.
2. Select the widget.
3. Ctrl + C.
4. Put the caret inside the table cell.
5. Ctrl + V.
6. Move to the next cell.
7. Ctrl + V.

Expected result

The image pastes correctly.

Current result

The image doesn't paste into the cell.

Other information

OS: Windows 10, MacOS X
Browser: All browsers
Release: 4.7.3