-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freeze browser with SourceEditing plugin #360
Comments
Same issue! If you press the source button & edit some text, after pressing save, the browser crashes. |
As reported in ckeditor/ckeditor5#11008
|
As a workaround, you can switch to the editing mode after clicking your buttons, then call For example: sourceEditing: any;
toggleEditor() {
this.sourceEditing = this.editor.plugins.get( 'SourceEditing' );
this.sourceEditing.isSourceEditingMode = false;
const data = this.editor.getData();
this.showEditor = !this.showEditor;
} |
I wonder if our fix in the main repo ckeditor/ckeditor5#14469 will not solve this problem! This was reported to React integration as well, was identified as an issue in the core, and fixed. Will be available, most likely in the next release! |
Could we verify if the issue is solved using the nightly builds? |
I've updated
and I still have this problem. |
I use
ckeditor5-angular
with custom build configurations from official site customization with pluginSourceEditing
.I get browser freezing when trying to destroy component with SourceEditing active mode (e.g. call
routing.navigate()
or change*ngIf
param)I've got some example project for reproduce it.
Steps to reproduce:
If you skip the (2) step all would be fine and browsers work great. Also, if you switch off source editing mode all would be fine too.
Also I found out that you will get the same behavior if you call some functions which affect
editor.fire()
function (e.g.editorInstance.getData()
) in the (3) step.I tried to reproduce this behavior without angular (only with
ckEditor
withSourceEditing
plugin) and I haven't got this behavior, all worked fine.I use this packages:
Full project example you can see here
The text was updated successfully, but these errors were encountered: