Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundling a different language #2143

Closed
Reinmar opened this issue Apr 27, 2017 · 7 comments · Fixed by ckeditor/ckeditor5-build-classic#14
Closed

Bundling a different language #2143

Reinmar opened this issue Apr 27, 2017 · 7 comments · Fixed by ckeditor/ckeditor5-build-classic#14
Assignees
@pomek
Labels
package:build-classic type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 11

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 27, 2017

By default, English strings are used in the bundles. We can make it configurable by specifying the language in build-config.js and reading it from Webpack config files.
@pomek pomek self-assigned this Aug 10, 2017
@Reinmar
Copy link
Member Author

Reinmar commented Aug 10, 2017

An example of using our Webpack plugin is here: https://github.com/ckeditor/ckeditor5-labs/tree/master/integrations/webpack-localization

@pomek
Copy link
Member

pomek commented Aug 10, 2017

A lot of translation' files are missing:

image

@Reinmar
Copy link
Member Author

Reinmar commented Aug 10, 2017

Maybe true right now since we haven't regenerated them for a long time. I'll do it today.

@pomek
Copy link
Member

pomek commented Aug 10, 2017

But it works :D

image

@pomek
Copy link
Member

pomek commented Aug 10, 2017

The question is – should we add the CKEditorWebpackPlugin every time or only if the specified language is other than en?

@Reinmar
Copy link
Member Author

Reinmar commented Aug 10, 2017

I think all the time. To KISS and to make sure that the translations (even en->en) are used.

@Reinmar
Copy link
Member Author

Reinmar commented Aug 10, 2017

I can't upload the translations for now: https://github.com/ckeditor/ckeditor5-dev/issues/249.

Reinmar referenced this issue in ckeditor/ckeditor5-build-classic Aug 15, 2017
@Reinmar
Merge pull request #14 from ckeditor/t/11
f4233a5 
Feature: Support for building the editor in another language than `en`. Closes #11.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-build-classic Oct 8, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:build-classic labels Oct 8, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 8, 2019
@pomek pomek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
package:build-classic type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

T/11: Bundling a different language ckeditor/ckeditor5-build-classic
3 participants
@Reinmar @pomek @mlewand