Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot start automated tests server at different port. #7225

Closed
tomalec opened this issue May 14, 2020 · 4 comments · Fixed by ckeditor/ckeditor5-dev#638
Closed

Cannot start automated tests server at different port. #7225

tomalec opened this issue May 14, 2020 · 4 comments · Fixed by ckeditor/ckeditor5-dev#638
Labels
package:dev type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@tomalec
Copy link
Contributor

tomalec commented May 14, 2020

Sometimes, I'd like to start the automated tests server at a port that is different than 9876

to run a test for multiple branches/clones,
the port is occupied by another server/same server than hanged/didn't release the port.

@pomek
Copy link
Member

pomek commented May 14, 2020

Karma prevents such situation out-of-the-box. If the port isn't available, Karma will look for another one.

First terminal:

image

Second terminal:

image

However, the ticket itself is valid.

Unfortunately,

to run a test for multiple branches/clones,

It won't work. Every spawn of yarn test creates an entry point (a file) for Karma: /ckeditor/ckeditor5/build/.automated-tests/entry-point.js

All processes will write to the file. We could add a port to the file name and everything should work.

@tomalec
Copy link
Contributor Author

tomalec commented May 14, 2020

Then it's only for:

the port is occupied by the server than hanged.

Steps to reproduce for me are:

  1. yarn run test --server,
  2. Ctrl + C,
  3. wait for the server to close,
  4. yarn run test --server,
  5. http://localhost:9876/ does not respond.

image

@tomalec
Copy link
Contributor Author

tomalec commented May 14, 2020

And at least to run test server for every close of the repo.

@tomalec
Copy link
Contributor Author

tomalec commented May 14, 2020

PRs are ready at #6818, ckeditor/ckeditor5-dev#638

pomek referenced this issue in ckeditor/ckeditor5-dev May 15, 2020
Feature: Make port number configurable for automated tests server. Closes #637.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-dev May 18, 2020
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. package:dev labels May 18, 2020
@Reinmar Reinmar added this to the iteration 32 milestone May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:dev type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants