Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operations which are not on the document should have base version null #4223

Closed
pjasiun opened this issue Dec 19, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1220
Closed

Operations which are not on the document should have base version null #4223

pjasiun opened this issue Dec 19, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1220
Assignees
@scofalik
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 14

Comments

@pjasiun
Copy link

pjasiun commented Dec 19, 2017

Operations which does not change the document (are applied on detached trees) does not increment document version. It means that multiple operations may have the same base version, what is not correct.

The proper way would be to set null as the base version for operations which works on detached trees.
pjasiun referenced this issue in ckeditor/ckeditor5-engine Jan 18, 2018
Merge pull request #1220 from ckeditor/t/1211
b527d7f 
Other: Operations that do not operate on a document should have `baseVersion` set to `null`. Closes #1211.
Fixed: Markers again are properly converted in `engine.controller.DataController`.
Fixed: Markers are cleared now before an operation is applied to `model.Document` tree to fix scenarios where marker range could not be converted to the view after the model changed.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added module:model type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 14
3 participants
@pjasiun @scofalik @mlewand