Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean disallowed attributes in a post-fixer #4235

Closed
pjasiun opened this issue Jan 8, 2018 · 9 comments
Closed

Clean disallowed attributes in a post-fixer #4235

pjasiun opened this issue Jan 8, 2018 · 9 comments
Labels
domain:dx This issue reports a developer experience problem or possible improvement. package:engine resolution:expired This issue was closed due to lack of feedback. type:debt This issue describes a technical debt. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@pjasiun
Copy link

pjasiun commented Jan 8, 2018

We should try to replace Schema.removeDisallowedAttributes method, which needs to be manually called, with a postfixer which will automatically remove disallowed attributes.

@Reinmar
Copy link
Member

Reinmar commented Jan 8, 2018

Right now this method is only used in deleteContent and insertContent. So all other algorithms (e.g. paragraph/heading/list commands) leave incorrect attributes in the model.

@Reinmar Reinmar changed the title Replace Schema.removeDisallowedAttributes method with a postfixer Clean disallowed attributes in a post-fixer Jan 15, 2018
@Reinmar
Copy link
Member

Reinmar commented Jan 15, 2018

I changed the title of this ticket because it's not about replacing the existing method, but about adding a post-fixer.

@Reinmar
Copy link
Member

Reinmar commented May 14, 2018

ckeditor/ckeditor5-list#104 will add a code which will need to be removed once this ticket is solved.

@Reinmar
Copy link
Member

Reinmar commented Mar 4, 2019

@Reinmar
Copy link
Member

Reinmar commented Jun 28, 2019

It seems that with more attributes for blocks in the model, the importance of this issue rises.

In the example below I was able to indent list items with margins, which is not allowed normally. I did that by turning indented paragraphs to a list.

image

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the next milestone Oct 9, 2019
@mlewand mlewand added module:model type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
@Reinmar Reinmar added domain:dx This issue reports a developer experience problem or possible improvement. type:debt This issue describes a technical debt. labels Jul 6, 2020
@pomek pomek modified the milestones: next, nice-to-have Nov 10, 2020
@kuku711
Copy link

kuku711 commented May 2, 2021

@Reinmar This issue gonna be resolved?
You mentioned this is critical, why it doesn`t get prioritize?
This issue should be as a bug and not improvement....

@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Jan 15, 2024
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:dx This issue reports a developer experience problem or possible improvement. package:engine resolution:expired This issue was closed due to lack of feedback. type:debt This issue describes a technical debt. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

6 participants