Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move consumables to conversionAPI in model to view conversion #4254

Closed
pjasiun opened this issue Jan 31, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1314
Closed

Move consumables to conversionAPI in model to view conversion #4254

pjasiun opened this issue Jan 31, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1314
Assignees
@scofalik
Labels
package:engine
Milestone
iteration 14

Comments

@pjasiun
Copy link

pjasiun commented Jan 31, 2018

In https://github.com/ckeditor/ckeditor5-engine/issues/1213 we moved consumables to conversionAPI in view to model conversion. We need to do the same in model to view conversion.
pjasiun referenced this issue in ckeditor/ckeditor5-engine Feb 20, 2018
Merge pull request #1314 from ckeditor/t/1294
731db37 
Other: Moved `consumable` parameter to `conversionApi` parameter in downcast. Closes #1294. Closes #1261.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

Moved consumable parameter to conversionApi parameter in downcast ckeditor/ckeditor5-engine
3 participants
@pjasiun @scofalik @mlewand