Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion utilities: specify model element name in downcastAttributeToAttribute #4270

Closed
scofalik opened this issue Feb 9, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1302
Closed

Conversion utilities: specify model element name in downcastAttributeToAttribute #4270

scofalik opened this issue Feb 9, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1302
Assignees
@scofalik
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 14

Comments

@scofalik
Copy link
Contributor

scofalik commented Feb 9, 2018

Follow-up to ckeditor/ckeditor5-engine#1274.

When refactoring Image plugin, I noticed, that new converters are missing one functionality. Right now, we support upcasting an attribute from given view element, but we don't support same thing for downcasting.

This means that we can't state that we define conversion of, for example, src attribute that is set on model image element.
pjasiun referenced this issue in ckeditor/ckeditor5-engine Feb 19, 2018
Merge pull request #1302 from ckeditor/t/1295
809ea24 
Other: Introduced several improvements to conversion helpers. Closes #1295. Closes #1293. Closes #1292. Closes #1291. Closes #1290. Closes #1305.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added module:conversion type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

T/1295 Further improvements to conversion helpers ckeditor/ckeditor5-engine
2 participants
@scofalik @mlewand