-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversion utilities: better handling for classes and styles in downcast #4272
Labels
Milestone
Comments
I wonder how configuration should look like for those cases. This concerns only downcastAttributeToAttribute( {
model: ...,
view: {
key: 'class',
value: 'myClass' | [ 'myClassA', 'myClassB' ]
}
} );
downcastAttributeToAttribute( {
model: ...,
view: {
key: 'style',
value: {
'font-size': '10px',
'font-family': 'Arial'
}
}
} ); Both of these are compatible with
|
pjasiun
referenced
this issue
in ckeditor/ckeditor5-engine
Feb 19, 2018
Other: Introduced several improvements to conversion helpers. Closes #1295. Closes #1293. Closes #1292. Closes #1291. Closes #1290. Closes #1305.
mlewand
added
module:conversion
type:improvement
This issue reports a possible enhancement of an existing feature.
package:engine
labels
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Follow-up to ckeditor/ckeditor5-engine#1274.
Right now there is no way to properly and easily handle setting and removing
class
es andstyle
s during downcasting.You can of course use the utilities and (un)set
class
attribute but this will overwrite already set classes.The text was updated successfully, but these errors were encountered: