Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HighlightAttributeElement #4278

Closed
pjasiun opened this issue Feb 16, 2018 · 1 comment
Closed

Remove HighlightAttributeElement #4278

pjasiun opened this issue Feb 16, 2018 · 1 comment
Assignees
@scofalik
Labels
package:engine type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 15

Comments

@pjasiun
Copy link

pjasiun commented Feb 16, 2018

Follow-up to https://github.com/ckeditor/ckeditor5-engine/issues/1210.

We decided that we should not have View Element subclasses. While removing all of them we forget about HighlightAttributeElement. It should be removed too.
@pjasiun pjasiun assigned szymonkups and unassigned szymonkups Feb 16, 2018
@pjasiun
Copy link
Author

pjasiun commented Mar 19, 2018

Closed by https://github.com/ckeditor/ckeditor5-engine/issues/1210.

@pjasiun pjasiun closed this as completed Mar 19, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 15 milestone Oct 9, 2019
@mlewand mlewand added module:view type:task This issue reports a chore (non-production change) and other types of "todos". package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 15
Development

No branches or pull requests
4 participants
@pjasiun @scofalik @szymonkups @mlewand