-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not expose both converters and helpers #4281
Comments
I remember, that on the latest TM some of us weren't sure about this change. cc @scofalik |
We were sure that we want to make it now, because we can always re-expose some things if needed. But we can't hide things which are published that easily. |
PS. Of course, unless, when working on this task, we'll realise that we need some of them even now :D |
So, in
While these should not be exported:
The tricky part here might be, how to modify tests to avoid using private functions. |
Not only the tests but also dev-utils/model. |
For dev-utils we may have protected API. |
I'll quote myself from ckeditor/ckeditor5-engine#1556:
|
As I thought – I actually had to use |
I'm closing this :D We're not going to do it anyway. |
I believe it was fixed by ckeditor/ckeditor5-engine#1613. |
Right not both "helpers" (like
downcastAttributeToElement
) and "converters" (likewrap
) are exposed. As long as we do not need both, we should limit exports only to "helpers" which can be call "converters". Current "converters" should be just a part or it, which is not exposed as separate function. It can even be merged into the single function.The text was updated successfully, but these errors were encountered: