Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differ: changes' offsets are incorrectly recalculated when multiple changes are done in one element #4284

Closed
scofalik opened this issue Feb 19, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1310
Closed

Differ: changes' offsets are incorrectly recalculated when multiple changes are done in one element #4284

scofalik opened this issue Feb 19, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1310
Assignees
@scofalik
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 14

Comments

@scofalik
Copy link
Contributor

Original issue: #849

The issue is caused by an incorrect change transformation. It happens when there are three changes in an element and:

  • the second change interfered with first change,
  • the third change interfered both with first change and the second change.

In that scenario, the second change has not been correctly transformed by the second change.
@scofalik scofalik self-assigned this Feb 19, 2018
pjasiun referenced this issue in ckeditor/ckeditor5-engine Feb 20, 2018
Merge pull request #1310 from ckeditor/t/1309
30dcf6c 
Fix: Corrected offsets transformation in `model.Differ` when multiple change items interfere with each other. Closes #1309. Closes ckeditor/ckeditor5#849.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added module:model type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 14
2 participants
@scofalik @mlewand