Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to select an object element in some cases #4444

Closed
Reinmar opened this issue Nov 19, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-engine#1608
Closed

Impossible to select an object element in some cases #4444

Reinmar opened this issue Nov 19, 2018 · 2 comments · Fixed by ckeditor/ckeditor5-engine#1608
Assignees
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Nov 19, 2018

The case is #1331.

It should be possible to make such a selection:

<div>[<div></div>]</div>

because div is marked as isObject (all objects are selectable).

However, that does not work. The reason why it works in the demo I created in that ticket is because I accidentally added:

	editor.model.schema.extend( '$text', {
		allowIn: 'div'
	} );

Which made this scenario fall into "selection is allowed in text" case.

@jodator
Copy link
Contributor

jodator commented Dec 7, 2018

Might be fixed by: ckeditor/ckeditor5-engine#1608. I'll check this.

@jodator jodator self-assigned this Dec 7, 2018
@jodator
Copy link
Contributor

jodator commented Dec 7, 2018

Yes. It does. ckeditor/ckeditor5-engine@1d54e74

scofalik referenced this issue in ckeditor/ckeditor5-engine Dec 20, 2018
Other: Add selection post-fixer improvements. Closes #1593.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 22 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants