Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection attributes conversion should fire attribute:key:$text event #4446

Closed
scofalik opened this issue Nov 26, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1598
Closed

Selection attributes conversion should fire attribute:key:$text event #4446

scofalik opened this issue Nov 26, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1598
Assignees
@pomek
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 22

Comments

@scofalik
Copy link
Contributor

As of now, when a selection attribute changes, DowncastDispatcher fires attribute:key conversion.

This is problematic:

  • selection takes attributes from surrounding text nodes,
  • attribute converter for a text node may be specified for attribute:key:$text event.

In this situation, the selection attribute won't get converted, because, as mentioned, it would fire attribute:key event.

To fix this, selection attribute conversion should fire attribute:key:$text event.
scofalik referenced this issue in ckeditor/ckeditor5-engine Dec 13, 2018
@scofalik
Merge pull request #1598 from ckeditor/t/1597
fd7734e 
Fix: Renamed the event during selection attributes conversion. `attribute:key` becomes to `attribute:key:$text`. Closes #1597.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 22 milestone Oct 9, 2019
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@pomek pomek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 22
Development

Successfully merging a pull request may close this issue.

Changed name of event during selection attributes conversion ckeditor/ckeditor5-engine
3 participants
@scofalik @pomek @mlewand