Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize converters output #3928

Closed
Reinmar opened this issue Dec 23, 2016 · 1 comment
Closed

Normalize converters output #3928

Reinmar opened this issue Dec 23, 2016 · 1 comment
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Reinmar
Copy link
Member

Reinmar commented Dec 23, 2016

When writing a "post-converter" you have a very tricky job to work with the output because there are at least 3 possible types of it – undefined, array or document fragment/element. This forced me to write some odd tests when working on this code:

https://github.com/ckeditor/ckeditor5-paragraph/blob/df99c8d48139bce3186462550e33ffdbf3218cec/src/paragraph.js#L191-L201

I think that you should be always able to expect the same kind of input and output.

@Reinmar
Copy link
Member Author

Reinmar commented Oct 3, 2018

Seems to be fixed by our conversion refactor a year ago.

@Reinmar Reinmar closed this as completed Oct 3, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added module:conversion type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants