Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insertContent should not clone nodes #4016

Closed
pjasiun opened this issue Mar 14, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#886
Closed

insertContent should not clone nodes #4016

pjasiun opened this issue Mar 14, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#886
Assignees
@ma2ciek
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 9

Comments

@pjasiun
Copy link

pjasiun commented Mar 14, 2017

Because of the clone in the insertContent method: https://github.com/ckeditor/ckeditor5-engine/blob/3e3839035c7d03af678b82eefea8fea83c66a625/src/controller/insertcontent.js#L130 the reference to the inserted node is broken. Inserting nodes should not be cloned.
@ma2ciek ma2ciek self-assigned this Mar 16, 2017
pjasiun referenced this issue in ckeditor/ckeditor5-engine Mar 23, 2017
Merge pull request #886 from ckeditor/t/869
45f0f33 
Fix: Changed insertContent behaviour, so it doesn't clone given nodes. Closes #869.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added module:controller type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@ma2ciek ma2ciek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma2ciek ma2ciek

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 9
Development

Successfully merging a pull request may close this issue.

T/869 insertContent shouldn't clone given nodes ckeditor/ckeditor5-engine
3 participants
@pjasiun @ma2ciek @mlewand