Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite selectionChange event #4022

Closed
oskarwrobel opened this issue Mar 20, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-engine#896
Closed

Infinite selectionChange event #4022

oskarwrobel opened this issue Mar 20, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-engine#896
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@oskarwrobel
Copy link
Contributor

How to reproduce?

  1. We need to enqueue some operation on the ModelDocument (can be empty function) on selectionChangeDone event.
editor.editing.view.on( 'selectionChangeDone', () => {
	editor.document.enqueueChanges( () => {} );
} );
  1. Place non-collapsed selection in the way that will end just after text with attributes.
<paragraph>F[o<$text bold="true">o b</$text>]ar</paragraph>

mar-20-2017 13-19-13

@pjasiun
Copy link

pjasiun commented Mar 20, 2017

It might mean that DOM is re-rendered and it can be connected with the composition issues.

/cc @f1ames

f1ames referenced this issue in ckeditor/ckeditor5-engine Mar 29, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-engine Mar 30, 2017
Fix: Renderer should not change the native selection if the one it's about to render is visually similar to the current one. Closes #887. Closes #880.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added module:selection type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants