Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectionObserver test is unstable #4028

Closed
Reinmar opened this issue Mar 24, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#893
Closed

SelectionObserver test is unstable #4028

Reinmar opened this issue Mar 24, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#893
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 9

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 24, 2017

https://travis-ci.org/ckeditor/ckeditor5/builds/214216219#L1295

"SelectionObserver should warn and not enter infinite loop" started failing recently.
Reinmar referenced this issue in ckeditor/ckeditor5-engine Mar 28, 2017
@Reinmar
Merge pull request #893 from ckeditor/t/889
8b859fb 
Other: Simplified `SelectionObserver`'s infinite loop check which should improve its stability. Closes #889.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 9
Development

Successfully merging a pull request may close this issue.

T/889 Fixing tests in SelectionObserver ckeditor/ckeditor5-engine
3 participants
@Reinmar @szymonkups @mlewand