Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fast keystroke auto linking of link–like text content in editable #4722

Closed
oleq opened this issue Aug 24, 2016 · 5 comments
Closed
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link resolution:expired This issue was closed due to lack of feedback. status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option). type:question This issue asks a question (how to...).

Comments

@oleq
Copy link
Member

oleq commented Aug 24, 2016

A followup of https://github.com/ckeditor/ckeditor5-link/issues/2#issuecomment-240374891.

Automated and "on keystroke" linking pasted and typed URLs. E.g. if you paste a URL, then it can be safely autolinked. But if you paste a lot of content or you typed that URL in some specific way and it wasn't autolinked, just press CTRL+K having selection in the URL text and that URL should be converted into a link.


The whole idea comes down to two cases:

Basic auto linking

As in https://github.com/ckeditor/ckeditor5-link/issues/6. If pasted content matches link pattern, it should be converted into <a href="http://foo">http://foo</a>. If not, or there's something else beside white spaces in the clipboard, it should be pasted as plain text.

image

Keystroke auto linking

If there's more in the clipboard (or simply in the content) than just a link, user can move selection to the link text, and use keyboard shortcut to automatically convert it into an <a> tag.

image

@Reinmar
Copy link
Member

Reinmar commented Aug 24, 2016

The autolinking feature will make this one either totally unnecessary or a low-priority one. It depends on autolinking aggressiveness which is a think that needs some attention. We cannot autolink things which users may not want to link – e.g. things that were already unlinked :D.

I mentioned this case because I saw that GDocs can do it and I've been using it myself. IIRC, GDocs isn't autolinking when you paste content and often I make a draft of some article outside and then paste it. So if we follow GDocs behaviour, this feature would be nice.

This feature could also be nice if someone didn't want to enable autolinking. I know that some auto-corrections can be frustrating – although, usually it's about correcting the first letter in a sentence, or similar uncertain things – linking sounds safer.

@oleq oleq changed the title Implement fast keystroke auto linking of editable text content Implement fast keystroke auto linking of link–like text content in editable Aug 24, 2016
@oleq
Copy link
Member Author

oleq commented Aug 25, 2016

This feature could also be nice if someone didn't want to enable autolinking. I know that some auto-corrections can be frustrating

👏

I think that link feature will have some nice tools to check what is around the selection in editable anyway, so this could be a very easy thing to implement using that API.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added domain:ui/ux This issue reports a problem related to UI or UX. module:ux status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option). type:question This issue asks a question (how to...). package:link labels Oct 9, 2019
@Reinmar Reinmar removed the module:ux label Jan 15, 2020
@jodator jodator added the squad:core Issue to be handled by the Core team. label Jul 28, 2020
@Reinmar Reinmar removed squad:blue squad:core Issue to be handled by the Core team. labels Jul 28, 2020
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added resolution:expired This issue was closed due to lack of feedback. and removed status:stale labels Jan 15, 2024
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link resolution:expired This issue was closed due to lack of feedback. status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option). type:question This issue asks a question (how to...).
Projects
None yet
Development

No branches or pull requests

6 participants