Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of LinkElement #4817

Closed
szymonkups opened this issue Jan 24, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-link#163
Closed

Get rid of LinkElement #4817

szymonkups opened this issue Jan 24, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-link#163
Assignees
@szymonkups
Labels
package:link type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 14

Comments

@szymonkups
Copy link
Contributor

During view refactoring we want to prevent ability to extend basic element classes. This will allow us to have limited set of base classes to handle. LinkElement is an empty class (extends AttributeElement) that is used to identify correct elements. This can be done using custom properties.
@szymonkups szymonkups self-assigned this Jan 24, 2018
pjasiun referenced this issue in ckeditor/ckeditor5-link Jan 24, 2018
Merge pull request #163 from ckeditor/t/162
3785e50 
Other: Removed LinkElement, using custom properties instead. Closes #162.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:link labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonkups szymonkups

Labels
package:link type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

Removed LinkElement ckeditor/ckeditor5-link
2 participants
@szymonkups @mlewand