Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to the media in a generic embed needs a "open in new tab" label #2735

Closed
Reinmar opened this issue Aug 21, 2018 · 3 comments
Closed

Link to the media in a generic embed needs a "open in new tab" label #2735

Reinmar opened this issue Aug 21, 2018 · 3 comments
Assignees
@oleq
Labels
package:media-embed status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 20

Comments

@Reinmar
Copy link
Member

Reinmar commented Aug 21, 2018

image

Same story as the link in link's balloon – it should be clear that you're about to leave the editor and open something.
@Reinmar
Copy link
Member Author

Reinmar commented Aug 21, 2018

I'm also unsure whether it should open the thing if the media isn't focused. I've just clicked on the link while I wanted to focus the widget. Let's add a tooltip first and see if it prevents such things...

@oleq
Copy link
Member

oleq commented Aug 24, 2018

Implemented the tooltip in ckeditor/ckeditor5-media-embed@c3204ef.

image

@oleq
Copy link
Member

oleq commented Aug 24, 2018

Closed in ckeditor/ckeditor5-media-embed#2.

@oleq oleq closed this as completed Aug 24, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-media-embed Oct 9, 2019
@mlewand mlewand added this to the iteration 20 milestone Oct 9, 2019
@mlewand mlewand added status:discussion type:improvement This issue reports a possible enhancement of an existing feature. package:media-embed labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:media-embed status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 20
Development

No branches or pull requests
3 participants
@Reinmar @oleq @mlewand