-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should the toolbar icon be improved? #2730
Labels
Milestone
Comments
In my opinion, there is no way to make 100% clear icon in this case, because like you said, it can be "everything" like Twitter, Google Maps, Reddit and hundreds of various type of content. I definitely prefer much more the current icon than v4 (it looks like an article or some kind of note?) and I'd stay with "video icon" 👍 |
👍 for the current icon. It is far more natural than the icon in CKE4. |
mlewand
added
status:discussion
type:question
This issue asks a question (how to...).
package:media-embed
labels
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
The toolbar icon in the MVP looks as follows
which
So what I proposed is a trade–off between the semantics of the feature (media embed is more than videos) and commonly used patterns (media is mostly videos these days).
There's also the matter of limited space in the icon and the fact that we shouldn't overdo it which makes it hard to express the entire scope of the feature (a.k.a. "embed almost anything"). IMO in v4 we made a poor job depicting the feature
This icon is very vague and I'd rather avoid this kind of communication. I think an incomplete but precise communication is way better than that.
WDYT?
cc @dkonopka
The text was updated successfully, but these errors were encountered: