Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the toolbar icon be improved? #2730

Closed
oleq opened this issue Aug 20, 2018 · 2 comments
Closed

Should the toolbar icon be improved? #2730

oleq opened this issue Aug 20, 2018 · 2 comments
Labels
package:media-embed status:discussion type:question This issue asks a question (how to...).
Milestone

Comments

@oleq
Copy link
Member

oleq commented Aug 20, 2018

The toolbar icon in the MVP looks as follows

image

which

  • on one hand could me misleading because the feature offers way more than videos, e.g. Twitter posts or Google Maps,
  • OTOH makes sense because the word "media" has strong association with videos (also audio and photos) and most likely the users will look for something like that in the toolbar,
  • OTTH makes sense because most of the embeds will, indeed, be videos

So what I proposed is a trade–off between the semantics of the feature (media embed is more than videos) and commonly used patterns (media is mostly videos these days).

There's also the matter of limited space in the icon and the fact that we shouldn't overdo it which makes it hard to express the entire scope of the feature (a.k.a. "embed almost anything"). IMO in v4 we made a poor job depicting the feature

image

This icon is very vague and I'd rather avoid this kind of communication. I think an incomplete but precise communication is way better than that.

WDYT?

cc @dkonopka

@dkonopka
Copy link
Contributor

In my opinion, there is no way to make 100% clear icon in this case, because like you said, it can be "everything" like Twitter, Google Maps, Reddit and hundreds of various type of content.

I definitely prefer much more the current icon than v4 (it looks like an article or some kind of note?) and I'd stay with "video icon" 👍

@pjasiun
Copy link

pjasiun commented Aug 21, 2018

👍 for the current icon. It is far more natural than the icon in CKE4.

@Reinmar Reinmar closed this as completed Aug 24, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-media-embed Oct 9, 2019
@mlewand mlewand added this to the iteration 20 milestone Oct 9, 2019
@mlewand mlewand added status:discussion type:question This issue asks a question (how to...). package:media-embed labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:media-embed status:discussion type:question This issue asks a question (how to...).
Projects
None yet
Development

No branches or pull requests

5 participants