Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI component/command naming concerns #2736

Closed
oleq opened this issue Aug 20, 2018 · 2 comments
Closed

UI component/command naming concerns #2736

oleq opened this issue Aug 20, 2018 · 2 comments
Assignees
@oleq
Labels
package:media-embed type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 20

Comments

@oleq
Copy link
Member

oleq commented Aug 20, 2018

Should button name be insertMedia or embedMedia? Or maybe mediaEmbed (vide imageUpload)?
@Reinmar
Copy link
Member

Reinmar commented Aug 21, 2018

It's closest to the image upload feature so mediaEmbed.

@oleq
Copy link
Member Author

oleq commented Aug 22, 2018

Closed in ckeditor/ckeditor5-media-embed@c215866.

@oleq oleq closed this as completed Aug 22, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-media-embed Oct 9, 2019
@mlewand mlewand added this to the iteration 20 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:media-embed labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:media-embed type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 20
Development

No branches or pull requests
3 participants
@Reinmar @oleq @mlewand