Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the "semantic embed" become a separate plugin? #2732

Closed
oleq opened this issue Aug 20, 2018 · 2 comments
Closed

Should the "semantic embed" become a separate plugin? #2732

oleq opened this issue Aug 20, 2018 · 2 comments
Labels
package:media-embed status:discussion type:question This issue asks a question (how to...).
Milestone

Comments

@oleq
Copy link
Member

oleq commented Aug 20, 2018

In v4 we have Media Embed and Semantic Media Embed as separate plugins.

In the MVP it's controlled via config.mediaEmbed.semanticDataOutput.

Concerns:

  • On one hand, it could help developers migrate and understand which is which,
  • It could save a couple of bytes because they're never used alongside
    • But come to think about that, they are used next to one another already in the MVP: when a preview–less embed is in the non-semantic output data, it's still expressed semantically because... there's no other way to do that. So maybe this separation does not make sense after all 🤔
      image
  • Extending builds with plugins in v4 was simple. In v5, it's not that easy so maybe less "plugin juggling" is better.
    • OTOH, I guess media embed will not be a part of any pre-compiled build, right? If not, developers would have to decide if they want it or not so they can just as well select semantic or non-semantic editing plugin in their build config at that stage.
@Reinmar
Copy link
Member

Reinmar commented Aug 20, 2018

Adding to the current milestone to remember to think about it.

@Reinmar
Copy link
Member

Reinmar commented Aug 24, 2018

We made a decision to keep them together. We may revisit this in the future if this feature will start to grow.

@Reinmar Reinmar closed this as completed Aug 24, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-media-embed Oct 9, 2019
@mlewand mlewand added this to the iteration 20 milestone Oct 9, 2019
@mlewand mlewand added status:discussion type:question This issue asks a question (how to...). package:media-embed labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:media-embed status:discussion type:question This issue asks a question (how to...).
Projects
None yet
Development

No branches or pull requests

3 participants