Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FF] Mutation with no change is not handled correctly #3136

Closed
scofalik opened this issue Feb 20, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-typing#182
Closed

[FF] Mutation with no change is not handled correctly #3136

scofalik opened this issue Feb 20, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-typing#182
Assignees
@scofalik
Labels
browser:firefox package:typing type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 22

Comments

@scofalik
Copy link
Contributor

In some particular cases, when <span> and space characters are involved, Firefox creates a mutation that doesn't change anything. Old text is same as new text. This crashes mutation handling algorithm.

Steps to reproduce

  1. Open CKEditor 5 demo (e.g. https://ckeditor.com/ckeditor-5/demo/)
  2. Put caret before space.
  3. Press Ctrl+B.
  4. Press space.
  5. Press space again or any other character.
Error: view-createPositionAt-offset-required: View#createPositionAt() requires the offset when the first parameter is a view item. Read more: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/support/error-codes.html#error-view-createPositionAt-offset-required
ckeditorerror.js:46
@scofalik scofalik self-assigned this Feb 20, 2019
pjasiun referenced this issue in ckeditor/ckeditor5-typing Feb 21, 2019
Merge pull request #182 from ckeditor/t/181
7175b6c 
Fix: Mutation handling crashed in particular scenarios (when the old text was the same as the new text). Closes #181.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-typing Oct 9, 2019
@mlewand mlewand added this to the iteration 22 milestone Oct 9, 2019
@mlewand mlewand added browser:firefox type:bug This issue reports a buggy (incorrect) behavior. package:typing labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
browser:firefox package:typing type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 22
2 participants
@scofalik @mlewand