Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use model.insertContent instead of model.Writer#insertText #3142

Closed
scofalik opened this issue May 20, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-typing#192
Closed

Use model.insertContent instead of model.Writer#insertText #3142

scofalik opened this issue May 20, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-typing#192
Assignees
@scofalik
Labels
package:typing type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 24

Comments

@scofalik
Copy link
Contributor

This change doesn't have any impact on how the feature works (well, it is a little less efficient but in reality, it should not matter). The advantage is that integration with track changes will be out of the box.
@scofalik scofalik self-assigned this May 20, 2019
pjasiun referenced this issue in ckeditor/ckeditor5-typing May 20, 2019
Merge pull request #192 from ckeditor/t/191
0aeb384 
Other: Use `model.insertContent` instead of `model.Writer#insertText`. Closes #191.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-typing Oct 9, 2019
@mlewand mlewand added this to the iteration 24 milestone Oct 9, 2019
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. package:typing labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:typing type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 24
Development

Successfully merging a pull request may close this issue.

Use model.insertContent instead of model.Writer#insertText ckeditor/ckeditor5-typing
2 participants
@scofalik @mlewand