Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the matter of UI resizing for BoxedEditorUIView #5223

Closed
oleq opened this issue May 13, 2016 · 3 comments
Closed

Resolve the matter of UI resizing for BoxedEditorUIView #5223

oleq opened this issue May 13, 2016 · 3 comments
Assignees
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@oleq
Copy link
Member

oleq commented May 13, 2016

BoxedEditorUI defines observable width and height attributes. They should be bound with the logic of the View to resize editor via editor.ui.[width | height]. It

A followup of https://github.com/ckeditor/ckeditor5-ui/issues/22.

@oleq oleq self-assigned this May 13, 2016
@Reinmar
Copy link
Member

Reinmar commented May 13, 2016

I'm not entirely sure we need this. So far you can easily resize editor using CSS. I implemented editorUI#width|height as a part of the prototype that we have in manual tests. It doesn't make that much sense though.

@oleq oleq removed their assignment May 13, 2016
@oleq
Copy link
Member Author

oleq commented Mar 31, 2017

Alright, let's get rid of those orphans then because they suggest developers this is actually something that works and we know this is not true. A misleading piece of code, that's all.

@oleq oleq self-assigned this Oct 4, 2017
@oleq oleq changed the title Implement UI resizing for BoxedEditorUIView Resolve the matter of UI resizing for BoxedEditorUIView Oct 4, 2017
@Reinmar
Copy link
Member

Reinmar commented Oct 4, 2017

PS. If you're looking for how to set CKEditor 5's height and width, then the news is that:

  • There's no config.height and config.width like in CKEditor 4.
  • You can just use CSS.

To set the height:

.ck-editor__editable {
    min-height: 400px;

    /* or: */
    height: 400px;
}

To set the width:

.ck-editor {
    width: 400px;
}

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 12 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:ui labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants