Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ComponentFactory case-insensitive #5422

Closed
Reinmar opened this issue Oct 12, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#325
Closed

Make ComponentFactory case-insensitive #5422

Reinmar opened this issue Oct 12, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#325
Assignees
@jodator
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 13

Comments

@Reinmar
Copy link
Member

Reinmar commented Oct 12, 2017

http://localhost/ckeditor5/build/docs/ckeditor5/1.0.0-alpha.1/framework/guides/support/error-codes.html#toolbarview-item-unavailable is the most frequently visited error code which means that a lot of people have problems with configuring their toolbars.

It's hard to guess how many of them make mistakes with letter cases but taken that plugins are named with UpperCase and buttons with lowerCase, there's a high chance that they actually do this mistake.
oleq referenced this issue in ckeditor/ckeditor5-ui Oct 16, 2017
@oleq
Merge pull request #325 from ckeditor/t/324
94417e9 
Other: The `ComponentFactory` should be case-insensitive. Closes #324.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 13 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:ui labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 13
Development

Successfully merging a pull request may close this issue.

Enhancement: Make ComponentFactory case-insensitive. ckeditor/ckeditor5-ui
3 participants
@Reinmar @jodator @mlewand