Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watchdog#setDestructor() could be optional #4704

Closed
ma2ciek opened this issue Aug 14, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-watchdog#26
Closed

Watchdog#setDestructor() could be optional #4704

ma2ciek opened this issue Aug 14, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-watchdog#26
Assignees
@ma2ciek
Labels
package:watchdog
Milestone
iteration 27 (v15...

Comments

@ma2ciek
Copy link
Contributor

ma2ciek commented Aug 14, 2019

While the Watchdog.setCreator() method is very useful when integrating editor with custom post-creation steps, the Watchdog.setDestructor() isn't, since most of the things from the creator can be destroyed automatically with editor.destroy() as all editor listeners will be destroyed.

WDYT?
@pjasiun
Copy link

pjasiun commented Aug 14, 2019

👍 Good idea.

@ma2ciek ma2ciek self-assigned this Aug 14, 2019
pjasiun referenced this issue in ckeditor/ckeditor5-watchdog Oct 2, 2019
Merge pull request #26 from ckeditor/t/21
5a9dc0c 
Other: Made the Watchdog#setDestructor() method optional and default to editor => editor.destroy(). Closes #21.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-watchdog Oct 9, 2019
@mlewand mlewand added this to the iteration 27 milestone Oct 9, 2019
@ma2ciek ma2ciek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma2ciek ma2ciek

Labels
package:watchdog
Projects
None yet
Milestone
iteration 27 (v15.0.0)
Development

Successfully merging a pull request may close this issue.

Made the Watchdog#setDestructor() method optional ckeditor/ckeditor5-watchdog
3 participants
@pjasiun @ma2ciek @mlewand