Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use icons instead of buttons with text in find and replace dropdown #10029

Closed
mlewand opened this issue Jul 1, 2021 · 1 comment
Closed

Use icons instead of buttons with text in find and replace dropdown #10029

mlewand opened this issue Jul 1, 2021 · 1 comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:find-and-replace resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:features Issue to be handled by the Features team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@mlewand
Copy link
Contributor

mlewand commented Jul 1, 2021

📝 Provide a description of the improvement

I think should go back to icon based buttons as proposed in #9719 (comment)

The labels are localizable (just like any other part of our UI) and I expect it will mess layout rather quickly. Although not sure if this is a real issue, I checked labels in German (produced by automatic translator so might not be correct)

And it still fits right. Not sure if there are languages that will have more spacious labels 🤔

Reason why we went with text labelled buttons instead of icons was that it's difficult to make obvious icons for replace / replace all.

So the question is, should we move to icon-based buttons with text showing up as a tooltip?


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. domain:ui/ux This issue reports a problem related to UI or UX. squad:features Issue to be handled by the Features team. package:find-and-replace labels Jul 1, 2021
@oleq
Copy link
Member

oleq commented Jul 28, 2021

The new design in #10229 will address this issue.

@oleq oleq closed this as completed Jul 28, 2021
@oleq oleq added the resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). label Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:find-and-replace resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). squad:features Issue to be handled by the Features team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants