Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imageStyle:full is missing #11090

Closed
awmartin opened this issue Jan 9, 2022 · 5 comments
Closed

imageStyle:full is missing #11090

awmartin opened this issue Jan 9, 2022 · 5 comments
Labels
resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). type:bug This issue reports a buggy (incorrect) behavior.

Comments

@awmartin
Copy link

awmartin commented Jan 9, 2022

📝 Provide detailed reproduction steps (if any)

Include the ImageStyle and ImageToolbar plugins and incorporate imageStyle:full in a toolbar as noted in the documentation here and here.

image: {
  toolbar: [ 'imageTextAlternative', '|', 'imageStyle:full', 'imageStyle:alignLeft', 'imageStyle:alignCenter', 'imageStyle:alignRight' ],
  styles: ['full', 'alignLeft', 'alignCenter', 'alignRight']
},

✔️ Expected result

A button should appear in the toolbar that when clicked, enables an image to span the full width of the editor.

According to the ImageStyle documentation (and as was available in previous versions), this style should be available as a predefined style:

The code sample above uses predefined image styles: 'full', 'alignLeft' and 'alignRight'.

Also the ImageToolbar documentation:

const imageConfig = {
  toolbar: [ 'imageStyle:full', 'imageStyle:side', '|', 'imageTextAlternative' ]
};

❌ Actual result

The button does not appear and a warning appears instead, stating:

toolbarview-item-unavailable Object { name: "imageStyle:full" }

❓ Possible solution

No idea. 🤔

📃 Other details

In addition, it seems that imageStyle:block and imageStyle:alignCenter behave identically, both producing the same button to align center.

  • Browser: Firefox 95.0.2
  • OS: macOS 12.1
  • First affected CKEditor version: 31.0.0 (also appears in 31.1.0)
  • Installed CKEditor plugins:
    "@ckeditor/ckeditor5-alignment": "^31.1.0",
    "@ckeditor/ckeditor5-autoformat": "^31.1.0",
    "@ckeditor/ckeditor5-basic-styles": "^31.1.0",
    "@ckeditor/ckeditor5-block-quote": "^31.1.0",
    "@ckeditor/ckeditor5-dev-utils": "^27.4.0",
    "@ckeditor/ckeditor5-dev-webpack-plugin": "^27.4.0",
    "@ckeditor/ckeditor5-editor-balloon": "^31.1.0",
    "@ckeditor/ckeditor5-editor-classic": "^31.1.0",
    "@ckeditor/ckeditor5-essentials": "^31.1.0",
    "@ckeditor/ckeditor5-heading": "^31.1.0",
    "@ckeditor/ckeditor5-highlight": "^31.1.0",
    "@ckeditor/ckeditor5-horizontal-line": "^31.1.0",
    "@ckeditor/ckeditor5-image": "^31.1.0",
    "@ckeditor/ckeditor5-indent": "^31.1.0",
    "@ckeditor/ckeditor5-link": "^31.1.0",
    "@ckeditor/ckeditor5-list": "^31.1.0",
    "@ckeditor/ckeditor5-media-embed": "^31.1.0",
    "@ckeditor/ckeditor5-mention": "31.1.0",
    "@ckeditor/ckeditor5-paragraph": "^31.1.0",
    "@ckeditor/ckeditor5-paste-from-office": "^31.1.0",
    "@ckeditor/ckeditor5-remove-format": "^31.1.0",
    "@ckeditor/ckeditor5-table": "^31.1.0",
    "@ckeditor/ckeditor5-theme-lark": "^31.1.0",
    "@ckeditor/ckeditor5-vue": "^2.0.1",
    "@ckeditor/ckeditor5-word-count": "^31.1.0",
@awmartin awmartin added the type:bug This issue reports a buggy (incorrect) behavior. label Jan 9, 2022
@theezeb
Copy link

theezeb commented Jan 10, 2022

Can confirm it's not working, i'm using decoupled-document editor
image

@Madejczyk
Copy link

Can you check imageStyle:block? Or this is not the same?

@awmartin
Copy link
Author

Can you check imageStyle:block? Or this is not the same?

It doesn't seem to be the same as :full, as I noted in the original issue.

@dufipl
Copy link
Contributor

dufipl commented Jan 21, 2022

Hello @awmartin,
There are some things that need to be clarified here: imageStyle:full is not supported anymore starting CKEditor 5 version 29.0.0. The documentation you are referring to is prepared for CKEditor 5 in version 11.1.1. This form of styling was replaced by the block style. Please take migration to version 29.0.0 guide as a reference in that matter: https://ckeditor.com/docs/ckeditor5/latest/builds/guides/migration/migration-to-29.html#image-styles
You can also take a look at the current version of documentation for image styling (https://ckeditor.com/docs/ckeditor5/latest/features/images/images-styles.html) which I hope will provide you sufficient and up to date information on that topic.
Therefore, this is not a bug so I will close the issue.
In case of additional issues/problems please do not hesitate to reach us out in the comments below.

@dufipl dufipl closed this as completed Jan 21, 2022
@dufipl dufipl added the resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). label Jan 21, 2022
@awmartin
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants